Skip to content

fix: TitleBar height shrinks when window width is reduced#1309

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/fix-titlebar-height-on-resize
Draft

fix: TitleBar height shrinks when window width is reduced#1309
Copilot wants to merge 3 commits intomasterfrom
copilot/fix-titlebar-height-on-resize

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026 •
edited
Loading

Two root causes were identified and fixed:

  1. TitleBar used loose BoxConstraints (minHeight: content != null ? 48 : 32, maxHeight: 48). With CrossAxisAlignment.stretch and all-flex children, the cross-axis size was clamped to minHeight rather than maxHeight, making the height unpredictable.

  2. _RenderTitleSubtitleOverflow reported zero height when elements were hidden. When the title or subtitle was hidden to fit a narrow window width, computeMinIntrinsicHeight and computeMaxIntrinsicHeight skipped hidden children (guarded by !childParentData.isHidden), returning 0. This stale state propagated up the layout tree, causing parent widgets to compute a smaller height for the TitleBar.

Changes

  • title_bar.dart — TitleBar.build(): Replace loose BoxConstraints with BoxConstraints.tightFor so the outer height is always deterministic:
    • content != null → 48px
    • content == null → 32px
// Before
BoxConstraints(minHeight: content != null ? 48 : 32, maxHeight: 48)

// After
BoxConstraints.tightFor(height: content != null ? 48 : 32)

  • title_bar.dart — _RenderTitleSubtitleOverflow: Remove the isHidden guard from computeMinIntrinsicHeight and computeMaxIntrinsicHeight so height is always computed from all children, regardless of their current visibility — consistent with _performLayout, which already measures all children for height.

  • navigation_view_test.dart: Add regression tests verifying TitleBar height is stable at 48px (with content) and 32px (without content) across both wide and narrow window widths.

Original prompt

This section details on the original issue you should resolve

<issue_title>🐛 When window is resized to smaller width, TitleBar shrinks in height</issue_title>
<issue_description>### Describe the bug
Upon resizing the window to a smaller size (specifically reducing the window width), the TitleBar shrinks in height, causing the inner Widgets to appear "clipped".

To Reproduce

Is also reproducible on the deployed documentation
Steps to reproduce the behavior:

  1. Shrink the web page in width
  2. Observe the TitleBar height reduces, and makes content appear "clipped"
Image

Expected behavior

TitleBar height should not change

Screenshots

✅ Window large enough ❌ Small window
Image Image

Additional context

My app's changes are available here: Codertainment/scrcpy_buddy#86</issue_description>

<agent_instructions>Update the tests and the changelog at the end.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@bdlukaa
fix: TitleBar height no longer shrinks when window is resized to smal…
449b8c0 
…ler width (#1340)

Co-authored-by: bdlukaa <45696119+bdlukaa@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix TitleBar height reduction on window resize fix: TitleBar height shrinks when window width is reduced Mar 17, 2026
Copilot AI requested a review from bdlukaa March 17, 2026 01:32
@bdlukaa
Copy link
Owner

bdlukaa commented Mar 17, 2026

@copilot The issue seems to happen when we hide an element of the title bar, such as the title, to make the title bar fit in the available width.

@bdlukaa
fix: _TitleSubtitleOverflow intrinsic height includes hidden children
9363d4e 
Co-authored-by: bdlukaa <45696119+bdlukaa@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 17, 2026 •
edited
Loading

@copilot The issue seems to happen when we hide an element of the title bar, such as the title, to make the title bar fit in the available width.

Exactly right — _RenderTitleSubtitleOverflow.computeMinIntrinsicHeight and computeMaxIntrinsicHeight were skipping hidden children (guarded by !childParentData.isHidden). So when the title was hidden to fit the available width, both methods returned 0, causing parent widgets to see a collapsed height for the TitleBar.

Fixed in 9363d4e: removed the isHidden guard from both intrinsic height methods so they always measure all children — matching the existing _performLayout behavior which already correctly computes maxHeight from all children regardless of visibility.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/flutter_infra_release/flutter/e4b8dca3f1b4ede4c30371002441c88c12187ed6/dart-sdk-linux-x64.zip
    • Triggering command: /usr/bin/curl curl --retry 3 --continue-at - --location --output /tmp/flutter/bin/cache/dart-sdk-linux-x64.zip REDACTED (http block)
    • Triggering command: /usr/bin/curl curl --retry 3 --continue-at - --location --output /tmp/flutter_clone/bin/cache/dart-sdk-linux-x64.zip REDACTED (http block)
  • https://storage.googleapis.com/flutter_infra_release/flutter/e4b8dca3f1b4ede4c30371002441c88c12187ed6/engine_stamp.json
    • Triggering command: /tmp/flutter_clone/bin/cache/dart-sdk/bin/dartvm /tmp/flutter_clone/bin/cache/dart-sdk/bin/dartvm --resolved_executable_name=/tmp/flutter_clone/bin/cache/dart-sdk/bin/dart --executable_name=/tmp/flutter_clone/bin/cache/dart-sdk/bin/dart --verbosity=error --snapshot=/tmp/flutter_clone/bin/cache/flutter_tools.snapshot --snapshot-kind=app-jit --packages=/tmp/flutter_clone/packages/flutter_tools/.dart_tool/package_config.json --no-enable-mirrors /tmp/flutter_clone/packages/flutter_tools/bin/flutter_tools.dart (http block)
  • https://storage.googleapis.com/flutter_infra_release/releases/releases_linux.json
    • Triggering command: /tmp/flutter_clone/bin/cache/dart-sdk/bin/dart /tmp/flutter_clone/bin/cache/dart-sdk/bin/dart pub upgrade --suppress-analytics /cac�� -t security fig OUTPUT -d 168.63.129.16 bash --no�� URI eKeyringURI -helper INVALID,NEW -j DROP -helper (http block)
    • Triggering command: /tmp/flutter_clone/bin/cache/dart-sdk/bin/dart /tmp/flutter_clone/bin/cache/dart-sdk/bin/dart pub upgrade --suppress-analytics -w -t security /usr/bin/bash OUTPUT -d 168.63.129.16 bash --no�� --noprofile conntrack -helper INVALID,NEW -j DROP -helper (http block)
    • Triggering command: /tmp/flutter_clone/bin/cache/dart-sdk/bin/dart /tmp/flutter_clone/bin/cache/dart-sdk/bin/dart pub upgrade --suppress-analytics zip -t security /usr/bin/ls /cache/dart-sdk (http block)
  • https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.24.0-stable.tar.xz
    • Triggering command: /usr/bin/wget wget REDACTED (http block)
  • https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.32.0-stable.tar.xz
    • Triggering command: /usr/bin/wget wget REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdlukaa bdlukaa Awaiting requested review from bdlukaa

Assignees

@bdlukaa bdlukaa

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 When window is resized to smaller width, TitleBar shrinks in height

2 participants

@bdlukaa